Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gsp to ecs tasks, remove gsp module #631

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Change gsp to ecs tasks, remove gsp module #631

merged 5 commits into from
Sep 30, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 25, 2024 •
edited
Loading

Pull Request

Description

  • change gsp to ecs tasks
  • remove gsp module
  • add sentry dsn

Try to keep ecs task names the same, so airflow works

Helps with #540

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review September 25, 2024 18:00
@peterdudfield peterdudfield merged commit 6ef2276 into main Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc